Phase 1 group 5 (S15, S16, S18, S19, L22, L23, L20, L21, L1 delete-half). - S15: the four-way focus/altitude system. setFocus was never called anywhere, so only the 'composite' branch was reachable. Deleted SplitStage, ReadoutStrip, InputMini, AltitudeNav, CompactAxis, the UI Focus type/prop, the focus branches, stripPinned and the vacuous keyboard gates. MiniMeters kept; engine.feedback.setFocus (a different, live thing) untouched. - S16 + L1: the decorative stratum that rendered real-looking controls driving nothing — A/B machinery, the fake seed, seededGradient + weightsRevision, snapshots, master volume, bpm, and the learningRate/decay/tame/spreadLevel sliders with their Drawers rows. Each was confirmed self-referential first. NOTE a real behaviour change falls out of dropping `snapshots`: Undo outside an active explore-and-place session used to pop a UI-only snapshot that restored noiseCap/seed. It is now simply inactive unless a genuine core-backed scratchpad undo exists. Geometric-dislike mode never had a real undo primitive in the core, so only the fake path is gone. - S18: BackendAdvanced.tsx and its Drawers block. It self-described as a duplicate of the inline OutputsBackendConfig editor and BOTH rendered in the same expanded drawer. OutputsBackendConfig already covers every backend. - S19: pruned ConsoleCtx to the fields Dock/Drawers/OutputsBackendConfig actually read; deleted the Axes type + axes/setAxis and the preset/setPreset/offsetActive chain (permanently 'Sculpt'/false). KEPT ctx.modes and ctx.setModeId despite having no reader today — the Phase 5 instrument picker (§7.6, adopted) is built on exactly that plumbing. - L22: the 5 dead primitives (Panel, StatusLine, ControlAxis, CurvePlot, Sparkline) and their barrel exports, plus the now-dead .mf-axis-input CSS. - L23: OutputControl/toOutputControl, ModeIconComponent and the BACKENDS catalogue; Drawers now reads modeDesc.label/description from OUTPUT_MODES, the surviving single catalogue. - L20: the solo-mode selector's two unimplemented options no longer pretend to be selectable. - L21: FeedbackController vestiges — seed/undoDepth options, maxUndo, and six ControllerEngine members nothing called (the finding named three; the other three are used on the real EngineApi by debug/probe.ts, a different interface, so removing them from ControllerEngine is safe). Gates: run-all-tests.sh ALL GREEN (typecheck, 33 Playwright specs).
82 lines
2.5 KiB
TypeScript
82 lines
2.5 KiB
TypeScript
/**
|
|
* Manifold — app root. The convertible Console (ConsoleApp) wired to the real
|
|
* engine, mounted under EngineProvider. ConsoleApp renders its single
|
|
* "composite" stage unconditionally (the dead focus/altitude system was
|
|
* deleted 2026-07 — simplification audit S15). The `?debug=1` probe is
|
|
* installed once the engine is live.
|
|
*/
|
|
|
|
import { useEffect } from 'react';
|
|
import { EngineProvider } from './engine/EngineProvider';
|
|
import type { EngineApiOptions } from './engine/engine-api';
|
|
import { useEngine } from './engine/useEngine';
|
|
import { installDebugProbe } from './debug/probe';
|
|
import { ConsoleApp } from './console';
|
|
|
|
/**
|
|
* Engine options derived from the URL. Under `?debug=1` (the Playwright /
|
|
* dev-probe gate) we pin a FIXED RNG seed so the net's initial weights — and
|
|
* therefore inference, feedback, and reshape behaviour — are deterministic run
|
|
* to run. Production (no debug flag) keeps the time-seeded default, so this
|
|
* never changes what a real user hears.
|
|
*/
|
|
function engineOptions(): EngineApiOptions {
|
|
if (typeof window === 'undefined') return {};
|
|
try {
|
|
const params = new URLSearchParams(window.location.search);
|
|
// Fixed seed + fixed per-tick dt ⇒ deterministic weights AND deterministic
|
|
// pipeline smoothing (the pipelines otherwise read performance.now()).
|
|
if (params.get('debug') === '1') return { seed: 0xc0ffee, debugClockDt: 1 / 60 };
|
|
} catch {
|
|
/* no URL (SSR / sandbox) — fall through */
|
|
}
|
|
return {};
|
|
}
|
|
|
|
function Loading() {
|
|
return (
|
|
<div
|
|
style={{
|
|
position: 'absolute',
|
|
inset: 0,
|
|
background: 'var(--bg)',
|
|
color: 'var(--fg)',
|
|
fontFamily: 'var(--font-mono)',
|
|
display: 'flex',
|
|
flexDirection: 'column',
|
|
alignItems: 'center',
|
|
justifyContent: 'center',
|
|
gap: 'var(--sp-3)',
|
|
}}
|
|
>
|
|
<strong
|
|
style={{
|
|
color: 'var(--accent)',
|
|
fontSize: 'var(--fs-2xl)',
|
|
letterSpacing: 'var(--ls-tight)',
|
|
}}
|
|
>
|
|
Manifold
|
|
</strong>
|
|
<span style={{ color: 'var(--fg-dim)', fontSize: 'var(--fs-xs)' }}>loading engine…</span>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
/** Installs the debug probe once the engine is in context. */
|
|
function ProbeInstaller() {
|
|
const engine = useEngine();
|
|
useEffect(() => {
|
|
if (engine) installDebugProbe(engine);
|
|
}, [engine]);
|
|
return null;
|
|
}
|
|
|
|
export function App() {
|
|
return (
|
|
<EngineProvider options={engineOptions()} fallback={<Loading />}>
|
|
<ProbeInstaller />
|
|
<ConsoleApp />
|
|
</EngineProvider>
|
|
);
|
|
}
|