The operator's call: "there should be one default learning rate and one
default max iterations and they should both be configurable at runtime."
There were SIX copies, not the four the audit described, and they did not
agree:
nisps/ml/mlp.hpp no-arg train() hardcoding 1.f / 1000u / 0.001f —
and firmware's ONLY training path calls exactly
this, so firmware had no runtime knob at all
wasm-iml.ts train() and trainAsync() TS default params (x2)
engine-api.ts learningRate ?? 1.0, with no maxIterations knob
vcv/src/iml.hpp 200 / 0.1 / 0.00001 — silently divergent
external_synth_midi.hpp its own kDefaultLearningRate/kDefaultMaxIterations
schemas/modes/*.json x9, identical, read by nobody at runtime
Now: schemas/ml_defaults.json is the single declaration (validated against a
sibling meta-schema, matching the midi_device.schema.json convention), codegen
emits it to C++ and TS in the same run, and MLPCore carries a TrainConfig whose
default member initialisers read the generated constant.
set_train_config()/nisps_ml_set_train_config() make it runtime-overridable on
every target; the explicit-argument train() overload is untouched. min_error
joins the tuple — it was duplicated identically and belongs with the other two.
The per-mode ml block loses default_learning_rate/default_max_iterations.
default_spread stays (genuinely wired on both targets) and input_channels stays
(codegen-time validated, real information for sound_analysis_midi).
VCV BEHAVIOUR CHANGE, deliberate: MEMLNaut.cpp constructs IML positionally and
relies on those defaults, so the module moves to 1000/1.0/0.001 — 5x the max
iterations, 10x the learning rate, and a 100x looser early-stop threshold. The
old values were never justified anywhere; they arrived with fbc68eb alongside
an unrelated module rewrite and no tuning rationale. Firmware and WASM have
shipped 1.0/1000 all along. It is now runtime-settable if this turns out worse.
The generated header lands in nisps/ml/generated/, not nisps/modes/generated/
where the rest of codegen output lives: training hyperparameters are an ML
fact, and nisps/ml sits below nisps/modes, so emitting them there would make
mlp.hpp include upward. The agent that built this flagged the directory-crossing
rather than hiding it; this is the fix. CI's generated-freshness gate learns the
new directory.
Gates: run-all-tests.sh ALL GREEN — 4/4 ctest, parity PASS (max delta 2.38e-7),
lint clean, manifold typecheck + 17 unit + 33 e2e (which exercise train() and
trainAsync() through a real browser).
157 lines
5 KiB
YAML
157 lines
5 KiB
YAML
name: CI
|
|
|
|
# Stream 11 verification pipeline.
|
|
#
|
|
# Two parallel jobs:
|
|
# * cpp-tests — builds nisps host C++ tests, builds nisps.wasm, runs
|
|
# the parity check, runs the lint script.
|
|
# * manifold-tests — typechecks the React manifold app, runs bun unit
|
|
# tests, builds the production bundle, runs Playwright
|
|
# e2e tests.
|
|
#
|
|
# Firmware compilation is NOT included in this workflow. Arduino-cli +
|
|
# rp2040 board package add ~2 minutes per run, and the verification value
|
|
# is low compared to the time cost; firmware build is documented as a
|
|
# manual `scripts/build-firmware.sh` step in README.md / CLAUDE.md.
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
pull_request:
|
|
branches: [main]
|
|
workflow_dispatch:
|
|
|
|
jobs:
|
|
cpp-tests:
|
|
name: C++ tests + WASM + parity + lint
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
submodules: recursive
|
|
|
|
- name: Install build deps
|
|
run: |
|
|
sudo apt-get update
|
|
sudo apt-get install -y --no-install-recommends \
|
|
cmake ninja-build build-essential perl
|
|
|
|
- name: Setup Emscripten
|
|
# mymindstorm/setup-emsdk caches the SDK between runs. Pin to a
|
|
# known-working version; bump deliberately.
|
|
uses: mymindstorm/setup-emsdk@v14
|
|
with:
|
|
version: '3.1.69'
|
|
actions-cache-folder: 'emsdk-cache'
|
|
|
|
- name: Verify emcc
|
|
run: emcc --version
|
|
|
|
- name: Setup Node (for parity_wasm.mjs)
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
|
|
- name: Build C++ tests + run ctest
|
|
env:
|
|
# CI is non-interactive — turn off colour for log readability.
|
|
CMAKE_BUILD_PARALLEL_LEVEL: '4'
|
|
run: bash scripts/build-cpp-tests.sh
|
|
|
|
# Freshness gate. manifold/public/nisps.{js,wasm} are TRACKED artifacts:
|
|
# the VPS webhook builds only manifold/, so vite copies whatever is
|
|
# committed into the production bundle. Prove the committed artifact
|
|
# still agrees with the C++ we just built, BEFORE the rebuild below
|
|
# overwrites it. A stale commit fails here instead of silently shipping.
|
|
- name: WASM freshness gate (committed artifact vs native)
|
|
env:
|
|
NISPS_PARITY_NO_BUILD: '1'
|
|
run: bash scripts/parity-check.sh
|
|
|
|
- name: Build WASM
|
|
# setup-emsdk puts emcc on PATH; build-wasm.sh picks it up via
|
|
# `command -v emcc`. No EMCC override needed.
|
|
run: bash scripts/build-wasm.sh
|
|
|
|
- name: Parity check (native vs WASM)
|
|
env:
|
|
NISPS_PARITY_NO_BUILD: '1' # we just built; don't re-build
|
|
run: bash scripts/parity-check.sh
|
|
|
|
- name: Lint
|
|
run: bash scripts/lint-cpp.sh
|
|
|
|
- name: Upload parity blobs on failure
|
|
if: failure()
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: parity-blobs
|
|
path: |
|
|
tests/cpp/parity_native.bin
|
|
tests/cpp/parity_wasm.bin
|
|
if-no-files-found: ignore
|
|
retention-days: 7
|
|
|
|
manifold-tests:
|
|
name: Manifold typecheck + unit + e2e
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Setup Bun
|
|
uses: oven-sh/setup-bun@v2
|
|
with:
|
|
bun-version: latest
|
|
|
|
# Enforces the "schema changes ship with regenerated C++ AND TypeScript
|
|
# in the same change" rule. Regenerate from schemas/ and fail if the
|
|
# committed outputs differ; then run the codegen golden test.
|
|
- name: Codegen is committed and idempotent
|
|
run: |
|
|
cd codegen
|
|
bun install --frozen-lockfile
|
|
bun run generate.ts
|
|
bun run generate-midi-devices.ts
|
|
bun run tests/golden_test.ts
|
|
cd ..
|
|
GEN_DIRS="nisps/modes/generated nisps/midi/generated nisps/ml/generated \
|
|
manifold/src/modes/generated manifold/src/midi-devices/generated"
|
|
git add -N $GEN_DIRS
|
|
if ! git diff --exit-code -- $GEN_DIRS; then
|
|
echo "::error::Generated outputs are stale. Run codegen and commit the result." >&2
|
|
exit 1
|
|
fi
|
|
|
|
- name: Install manifold deps
|
|
working-directory: manifold
|
|
run: bun install --frozen-lockfile
|
|
|
|
- name: Typecheck
|
|
working-directory: manifold
|
|
run: bun run typecheck
|
|
|
|
- name: Unit tests
|
|
working-directory: manifold
|
|
run: bun run test
|
|
|
|
- name: Build manifold bundle
|
|
working-directory: manifold
|
|
run: bun run build
|
|
|
|
- name: Install Playwright browsers
|
|
working-directory: manifold
|
|
run: bunx playwright install --with-deps chromium
|
|
|
|
- name: Run Playwright tests
|
|
working-directory: manifold
|
|
run: bunx playwright test
|
|
|
|
- name: Upload Playwright report on failure
|
|
if: failure()
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: playwright-report
|
|
path: manifold/playwright-report/
|
|
retention-days: 7
|