Third failure uncovered by the restored pipeline. With checkout and the C++ build fixed, CI reached the WASM step and died on `[build-wasm] emcc not found at emcc`: ci.yml passed `EMCC: emcc`, but the script's existence check (`[[ ! -x "$EMCC" && ! -f "$EMCC" ]]`) only understands paths, so it looked for a file literally named "emcc" in the working directory. This has been broken for as long as the override existed; it was invisible because CI never got past checkout to run it. Resolve a bare command name through `command -v` before the check, and drop the now-redundant EMCC override in ci.yml — setup-emsdk already puts emcc on PATH, which is what the script's own default looks for. Verified by invoking it the way CI does: `EMCC=emcc bash scripts/build-wasm.sh` now builds. Incidentally confirms the new freshness gate is sound — the local toolchain is the same pinned emcc 3.1.69, and the rebuild reproduced the committed artifact byte-for-byte. run-all-tests.sh ALL GREEN.
157 lines
5 KiB
YAML
157 lines
5 KiB
YAML
name: CI
|
|
|
|
# Stream 11 verification pipeline.
|
|
#
|
|
# Two parallel jobs:
|
|
# * cpp-tests — builds nisps host C++ tests, builds nisps.wasm, runs
|
|
# the parity check, runs the lint script.
|
|
# * manifold-tests — typechecks the React manifold app, runs bun unit
|
|
# tests, builds the production bundle, runs Playwright
|
|
# e2e tests.
|
|
#
|
|
# Firmware compilation is NOT included in this workflow. Arduino-cli +
|
|
# rp2040 board package add ~2 minutes per run, and the verification value
|
|
# is low compared to the time cost; firmware build is documented as a
|
|
# manual `scripts/build-firmware.sh` step in README.md / CLAUDE.md.
|
|
|
|
on:
|
|
push:
|
|
branches: [main, port-solidjs]
|
|
pull_request:
|
|
branches: [main, port-solidjs]
|
|
workflow_dispatch:
|
|
|
|
jobs:
|
|
cpp-tests:
|
|
name: C++ tests + WASM + parity + lint
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
submodules: recursive
|
|
|
|
- name: Install build deps
|
|
run: |
|
|
sudo apt-get update
|
|
sudo apt-get install -y --no-install-recommends \
|
|
cmake ninja-build build-essential perl
|
|
|
|
- name: Setup Emscripten
|
|
# mymindstorm/setup-emsdk caches the SDK between runs. Pin to a
|
|
# known-working version; bump deliberately.
|
|
uses: mymindstorm/setup-emsdk@v14
|
|
with:
|
|
version: '3.1.69'
|
|
actions-cache-folder: 'emsdk-cache'
|
|
|
|
- name: Verify emcc
|
|
run: emcc --version
|
|
|
|
- name: Setup Node (for parity_wasm.mjs)
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
|
|
- name: Build C++ tests + run ctest
|
|
env:
|
|
# CI is non-interactive — turn off colour for log readability.
|
|
CMAKE_BUILD_PARALLEL_LEVEL: '4'
|
|
run: bash scripts/build-cpp-tests.sh
|
|
|
|
# Freshness gate. manifold/public/nisps.{js,wasm} are TRACKED artifacts:
|
|
# the VPS webhook builds only manifold/, so vite copies whatever is
|
|
# committed into the production bundle. Prove the committed artifact
|
|
# still agrees with the C++ we just built, BEFORE the rebuild below
|
|
# overwrites it. A stale commit fails here instead of silently shipping.
|
|
- name: WASM freshness gate (committed artifact vs native)
|
|
env:
|
|
NISPS_PARITY_NO_BUILD: '1'
|
|
run: bash scripts/parity-check.sh
|
|
|
|
- name: Build WASM
|
|
# setup-emsdk puts emcc on PATH; build-wasm.sh picks it up via
|
|
# `command -v emcc`. No EMCC override needed.
|
|
run: bash scripts/build-wasm.sh
|
|
|
|
- name: Parity check (native vs WASM)
|
|
env:
|
|
NISPS_PARITY_NO_BUILD: '1' # we just built; don't re-build
|
|
run: bash scripts/parity-check.sh
|
|
|
|
- name: Lint
|
|
run: bash scripts/lint-cpp.sh
|
|
|
|
- name: Upload parity blobs on failure
|
|
if: failure()
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: parity-blobs
|
|
path: |
|
|
tests/cpp/parity_native.bin
|
|
tests/cpp/parity_wasm.bin
|
|
if-no-files-found: ignore
|
|
retention-days: 7
|
|
|
|
manifold-tests:
|
|
name: Manifold typecheck + unit + e2e
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Setup Bun
|
|
uses: oven-sh/setup-bun@v2
|
|
with:
|
|
bun-version: latest
|
|
|
|
# Enforces the "schema changes ship with regenerated C++ AND TypeScript
|
|
# in the same change" rule. Regenerate from schemas/ and fail if the
|
|
# committed outputs differ; then run the codegen golden test.
|
|
- name: Codegen is committed and idempotent
|
|
run: |
|
|
cd codegen
|
|
bun install --frozen-lockfile
|
|
bun run generate.ts
|
|
bun run generate-midi-devices.ts
|
|
bun run tests/golden_test.ts
|
|
cd ..
|
|
GEN_DIRS="nisps/modes/generated nisps/midi/generated \
|
|
manifold/src/modes/generated manifold/src/midi-devices/generated"
|
|
git add -N $GEN_DIRS
|
|
if ! git diff --exit-code -- $GEN_DIRS; then
|
|
echo "::error::Generated outputs are stale. Run codegen and commit the result." >&2
|
|
exit 1
|
|
fi
|
|
|
|
- name: Install manifold deps
|
|
working-directory: manifold
|
|
run: bun install --frozen-lockfile
|
|
|
|
- name: Typecheck
|
|
working-directory: manifold
|
|
run: bun run typecheck
|
|
|
|
- name: Unit tests
|
|
working-directory: manifold
|
|
run: bun run test
|
|
|
|
- name: Build manifold bundle
|
|
working-directory: manifold
|
|
run: bun run build
|
|
|
|
- name: Install Playwright browsers
|
|
working-directory: manifold
|
|
run: bunx playwright install --with-deps chromium
|
|
|
|
- name: Run Playwright tests
|
|
working-directory: manifold
|
|
run: bunx playwright test
|
|
|
|
- name: Upload Playwright report on failure
|
|
if: failure()
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: playwright-report
|
|
path: manifold/playwright-report/
|
|
retention-days: 7
|