memlnaut-nisps/nisps/modes/slp_workshop.hpp
monkey-w1n5t0n f5b571412f refactor(codegen): codegen owns mode identity, per-mode schemas and net dims
Phase 3 (S1, S5, S6, S25, L11, L37, ST11, ST12). Behaviour-preserving by
construction: the diff on the generated directories is PURELY ADDITIVE (217
insertions, 0 deletions), so no emitted constant changed value. This moves where
truth lives; it does not change what truth says.

- S5: nine mode headers each carried a mechanically identical 12-field
  positional ParamSchema aggregate. codegen now emits one
  `inline constexpr ParamSchema k<Mode>Schema` per mode, and the struct itself
  moved into generated/schema_types.hpp. Each param_schema() is a one-line
  return.
- S6 + S25: every mode hand-typed its net shape a second time as MLP template
  args, duplicating the schema's own dims. codegen emits a `<Mode>MLP` alias
  built from the already-emitted constants (not re-literalled), and all nine
  modes use it. NMaxExamples still defaults from kDefaultMaxExamples (Phase 2).
- S1: model.ts hand-imported all nine schemas by name and hand-paired each with
  its overlay — so the SET of modes was hand-maintained and could silently drift
  from codegen. codegen now emits ALL_MODE_SCHEMAS; SCHEMA_MODE_OVERLAYS is
  purely display truth (label/glyph/css/order), which stays hand-curated.
- L37: deleted the hand-written modeEngineId switch, which duplicated
  schema.engine_id and silently defaulted unknown modes to 'thru'. Routes on
  MFMode.engineId with exactly one documented exception: sound_analysis_midi
  declares engine_id 'thru' because its ModeBase audio slot really is
  NoOpEngine, while it separately drives the real AnalysisEngine.
- L11: ExternalSynthMIDIMode's shape was literal in two places; now named once
  in an ext_synth_defaults namespace with an ExtSynthMIDIMLP alias. Full folding
  into the JSON pipeline is NOT done and the reason is recorded in-file: it is a
  template family over an externally-supplied Device and variable NOut, with no
  single (device, NOut) schema to author.
- ST12: extracted codegen/lib.ts for the helpers both generators duplicated, and
  corrected the comment that claimed they had to be separate. Proof the
  extraction was behaviour-free: regenerating the MIDI-device outputs produces a
  byte-identical tree.
- ST11: deleted codegen/templates/ — dead "reference" files no generator reads,
  already drifted from the real emitters.

Gates: run-all-tests.sh ALL GREEN; codegen idempotent (re-running both
generators yields no further diff), which is what CI's dirty-diff gate checks.
2026-07-21 14:02:23 +02:00

63 lines
2.1 KiB
C++

// nisps/modes/slp_workshop.hpp — SLP-Workshop mode binding.
//
// The Synth Library Portland workshop instrument. It reuses the MEMLCelium
// engine and MLP shape verbatim (4 input channels → MLP[4,10,14,18,56] →
// MEMLCeliumEngine, sequencer ticked internally in process()), but exists as
// a distinct mode so the workshop firmware carries its own identity (preset
// dir, display name) and foregrounds the adaptive-learning gestures that now
// live in ModeBase for every mode:
//
// - Jolt — held gesture, continuously morphs a scatter of weights and
// freezes them on release (Base::jolt_press/jolt_release).
// - OU explore — Ornstein-Uhlenbeck random walk on the output vector
// (Base::set_explore_intensity).
//
// Both were ported from upstream memllib InterfaceRL (see ml/jolt.hpp,
// ml/ou_noise.hpp). Because they sit in the shared base, the synthesis
// mapping here is identical to MEMLCeliumMode — only the surfaced controls
// and identity differ.
#pragma once
#include <cstddef>
#include <cstdint>
#include <span>
#include <string_view>
#include "../core/concepts.hpp"
#include "../core/perf.hpp"
#include "../core/types.hpp"
#include "../engines/memlcelium.hpp"
#include "base.hpp"
#include "generated/slp_workshop_schema.hpp"
namespace nisps::modes {
class SLPWorkshopMode : public ModeBase<
SLPWorkshopMode,
MEMLCeliumEngine,
generated::SlpWorkshopMLP,
4u> {
public:
using Base = ModeBase<SLPWorkshopMode, MEMLCeliumEngine,
generated::SlpWorkshopMLP, 4u>;
using Base::Base;
static constexpr std::string_view mode_id() noexcept {
return generated::kSlpWorkshopModeId;
}
static constexpr const ParamSchema& param_schema() noexcept {
return generated::kSlpWorkshopSchema;
}
NISPS_FORCE_INLINE void set_playing(bool playing) noexcept {
engine_.set_playing(playing);
}
NISPS_FORCE_INLINE void update_bpm(float bpm) noexcept {
engine_.update_bpm(bpm);
}
};
static_assert(Mode<SLPWorkshopMode>, "SLPWorkshopMode must satisfy nisps::Mode");
} // namespace nisps::modes