memlnaut-nisps/manifold/tests/e2e/probe-api.spec.ts
monkey-w1n5t0n a77770f95d feat: curve truth, DriverConfig, real telemetry, engine benchmark
Four items from one workflow, committed together because their build and CI
wiring genuinely interleaves — nisps/CMakeLists.txt, run-all-tests.sh and
ci.yml each carry hunks from two of them, and the stage renumbering (1/5 ->
1/6) touches every line. Splitting would produce commits that do not build,
which is worse than a commit that does four things and says so.

S26 part 2 — the curve declaration now matches reality. params[].curve stays
the mode-wide DEFAULT; a voice_spaces entry may now be {name, curve_overrides}
declaring only the slots where THAT voice space deviates. The 6 modes with one
voice space are byte-identical. The values were derived MECHANICALLY by a new
codegen/curve-audit.ts that models the four idioms a p[N]*p[N] regex misses
(alias form, memlcelium's implicit-counter sq() lambda, loop-generated indices,
smooth_params_), inlines helpers, and RAISES rather than guessing when it
cannot reduce an expression. A drift gate cross-checks 1179 (voice space x
param) slots against engine source on every run and was proved to fail loudly
on three drift classes. Application stays in the engine: nisps/engines,
nisps/pipeline and nisps/core are untouched, generated output is pure insertion
(755 insertions, 0 deletions), and the rebuilt nisps.wasm was byte-identical.

S4 / 7.2 — firmware reads the active mode's driver config at mode start, and
mic/line is real. My brief assumed the engine owns this; the code disagreed and
the code was right. sound_analysis_midi's EngineT is NoOpEngine — the mic lives
on a separately-composed AnalysisEngine member — so engine-level wiring would
have compiled, passed every gate, and left the one mic mode on line input.
Hence a mode-level seam defaulting to engine().driver_config(). Separately,
DriverConfig's defaults (line_level 0, output_volume 1.0) had drifted from
memllib's actual 3/0.8 because nothing had ever read them; wiring them as-is
would have made every silent mode louder and its line input maximally
insensitive — a behaviour change disguised as plumbing. Now pinned by a test.
Also: GetSysClockSpeed() panic()s on unsupported sample rates and runs on the
first line of setup(), so sample_rate needed a fallback ahead of clock setup.
CI's firmware env list gains soundanalysismidi — it is the only mic variant and
nothing else compiles that path.

Plan 5e — telemetry is real. A loss_history C-API entry across the full 5-layer
chain lets the browser read the per-iteration loss the core already records.
The audit named one fabrication site; there were two — wasm-iml.ts's
synchronous train() published lossHistory: [loss] as well. A third, ctx.loss,
was not merely dead but actively synthetic (fallbacks of prev * 0.82 and a
literal 0.5, rendered by nothing) and is deleted. The firmware buffer stays
untouched, per the L25 call. EngineApi.lossHistory() reads spine state rather
than the MLP handle, because trainAsync() fits on the worker's mirror net and
the handle would give a subtly-wrong second answer.

Plan 5f — engine throughput is measurable. One source compiled twice (CMake
natively, emcc for WASM) so the targets compare directly and no WASM export is
added. Sequencers are driven into a working state, and every row prints its own
working-state evidence so a number produced by an idle engine is visible rather
than plausible. Reports, never asserts: a wall-clock threshold on shared
hardware is meaningless or flaky, same call as the firmware size job.

ALIGNMENT: the telemetry defect is deleted (built, not deferred); the
performance defect is rewritten to what is actually left — these are HOST
numbers, and nothing measures the RP2350 at 150 MHz, which is the target the
mission's constraint is about. Q4 (memllib ownership) and Q5 (legacy feedback
modes) are closed.

Corrections to my own earlier claims, both found by agents contradicting the
brief: manifold/ONBOARDING.md was NOT "now accurate" — its primitives list
still named five deleted primitives and cited a seededGradient() that does not
exist. And the parity harness misses the sequencer engines because it runs 128
frames while their sequencers evaluate every 400-500 samples, NOT because
all-params-0.5 fails to trigger them (it does trigger: 0.5 maps to ratio 2,
firing three times per bar). The fix is a longer window, not different params.

Gates: run-all-tests.sh ALL GREEN — 4/4 ctest, parity PASS, lint clean, curve
drift 1179 slots ok, 39 e2e (was 33). Firmware: 5 envs built including the mic
variant.
2026-07-21 22:02:23 +02:00

237 lines
10 KiB
TypeScript

/**
* Debug-probe API contract — `window.__nisps` (gated behind `?debug=1`).
*
* Ported from `playground/tests/e2e/ml-engine.spec.ts`. This is the ENGINE
* contract, not playground UI, so it survives the playground's retirement:
* every probe accessor must return the documented shape and never throw.
*
* Adaptations vs. the playground original:
* - Manifold's net is runtime-shaped and (since P5.3) boots at the BOOT MODE's
* schema `ml` config, so dims + weight count are derived from the imported
* schema, never hard-coded.
* - No `probe.__init()` / no `mlStore.iml` poke-through: Manifold's probe
* exposes `addExample()` and `routedOutputs()` directly, so the training
* tests drive the real public surface instead of an escape hatch.
* - The playground's `test.skip(!probeReady)` guard is gone — on Manifold the
* probe is only installed once WASM is live, so a not-ready probe is a
* genuine failure, not a pending-stream skip.
*/
import { test, expect } from '@playwright/test';
import { loadProbe, getOutputs, countChanged, allWithin, weightCountFromMl } from './helpers';
import { PafSynthSchema } from '../../src/modes/generated';
// The boot mode is paf_synth; all dims derive from its schema `ml` config.
const N_OUTPUTS = PafSynthSchema.ml.output_size; // 33
const WEIGHT_COUNT = weightCountFromMl(PafSynthSchema.ml); // 4→[10,10,14]→33 = 809
// 4 layers (3 hidden + output) * 4 stats per layer.
const LAYER_STATS = 16;
const EXAMPLE_LOW = { input: [0.1, 0.9], output: new Array(N_OUTPUTS).fill(0.1) };
const EXAMPLE_HIGH = { input: [0.9, 0.1], output: new Array(N_OUTPUTS).fill(0.9) };
test.beforeEach(async ({ page }) => {
await loadProbe(page);
});
test.describe('ML engine — debug probe contract', () => {
test('probe is installed and reports ready', async ({ page }) => {
const kind = await page.evaluate(() => typeof window.__nisps);
expect(kind).toBe('object');
const ready = await page.evaluate(() => window.__nisps!.__ready);
expect(ready).toBe(true);
});
test('initial outputs are bounded in [0, 1]', async ({ page }) => {
const outs = await getOutputs(page);
expect(outs).toHaveLength(N_OUTPUTS);
expect(allWithin(outs, 0, 1)).toBe(true);
});
test('initial state is 0 examples and no loss', async ({ page }) => {
const count = await page.evaluate(() => window.__nisps!.getExampleCount());
expect(count).toBe(0);
const loss = await page.evaluate(() => window.__nisps!.getLoss());
expect(loss).toBeNull();
});
test('randomise changes outputs', async ({ page }) => {
await page.evaluate(() => window.__nisps!.setInputs(0.3, 0.7));
const before = await getOutputs(page);
await page.evaluate(() => window.__nisps!.randomise());
await page.evaluate(() => window.__nisps!.setInputs(0.3, 0.7));
const after = await getOutputs(page);
expect(countChanged(before, after, 1e-3)).toBeGreaterThan(0);
});
test('setInputs runs inference and yields bounded outputs', async ({ page }) => {
await page.evaluate(() => window.__nisps!.setInputs(0.25, 0.75));
const outs = await getOutputs(page);
expect(outs).toHaveLength(N_OUTPUTS);
expect(allWithin(outs, 0, 1)).toBe(true);
});
test('thumbsUp returns a finite FeedbackAction and keeps the count sane', async ({ page }) => {
await page.evaluate(() => window.__nisps!.setInputs(0.4, 0.6));
const action = await page.evaluate(() => window.__nisps!.thumbsUp());
expect(typeof action).toBe('number');
expect(Number.isFinite(action)).toBe(true);
const count = await page.evaluate(() => window.__nisps!.getExampleCount());
expect(Number.isInteger(count)).toBe(true);
expect(count).toBeGreaterThanOrEqual(0);
});
test('thumbsDown returns a finite action; a geometric dislike changes outputs', async ({ page }) => {
// Under the geometric-dislike core (one-core-engine P3) a dislike trains AWAY
// from the HEARD (post-pipeline) vector. Passing the net's OWN output — as the
// bare thumbsDown probe does — is intentionally inert (zero MSE derivative), so
// we assert only its SHAPE there and drive a real, distinct heard vector for
// the behaviour. Everything runs in ONE evaluate so the app's input rAF loop
// cannot drift the input-pipeline EMA between reads (which would make the delta
// timing-dependent).
const r = await page.evaluate((n) => {
const p = window.__nisps!;
p.setFeedbackMode('avoid'); // geometric dislike proto mode maps to core Avoid
p.setAvoidStyle(0); // Geometric (default)
p.setInputs(0.3, 0.7);
// Contract: thumbsDown returns a finite FeedbackAction and never throws.
const action = p.thumbsDown();
// Behaviour: a dislike with a heard vector DISTINCT from the output trains a
// real push → outputs change deterministically.
const before = Array.from(p.getOutputs());
const heard = new Array(n).fill(0.9);
p.dislikeGeometric(heard, 1.0); // trains + re-processes at the same input
const after = Array.from(p.getOutputs());
let changed = 0;
for (let i = 0; i < before.length; ++i) {
if (Math.abs(before[i]! - after[i]!) > 1e-4) ++changed;
}
return { action, changed };
}, N_OUTPUTS);
expect(typeof r.action).toBe('number');
expect(Number.isFinite(r.action)).toBe(true);
expect(r.changed).toBeGreaterThan(0);
});
test('addExample reports success and bumps the example count', async ({ page }) => {
const ok = await page.evaluate(
([ex]) => window.__nisps!.addExample(ex.input, ex.output),
[EXAMPLE_LOW],
);
expect(typeof ok).toBe('boolean');
expect(ok).toBe(true);
const count = await page.evaluate(() => window.__nisps!.getExampleCount());
expect(count).toBe(1);
});
test('train() with two contrasting examples does not increase loss', async ({ page }) => {
await page.evaluate(
([low, high]) => {
window.__nisps!.addExample(low.input, low.output);
window.__nisps!.addExample(high.input, high.output);
},
[EXAMPLE_LOW, EXAMPLE_HIGH],
);
const loss1 = await page.evaluate(() => window.__nisps!.train());
expect(typeof loss1).toBe('number');
expect(Number.isFinite(loss1)).toBe(true);
expect(loss1).toBeGreaterThanOrEqual(0);
const loss2 = await page.evaluate(() => window.__nisps!.train());
expect(loss2).toBeLessThanOrEqual(loss1 + 1e-6);
});
test('getLossHistory returns the REAL per-iteration curve after a sync train', async ({ page }) => {
// Empty until something has actually trained — never a placeholder.
expect(await page.evaluate(() => window.__nisps!.getLossHistory().length)).toBe(0);
const hist = await page.evaluate(
([low, high]) => {
window.__nisps!.addExample(low.input, low.output);
window.__nisps!.addExample(high.input, high.output);
window.__nisps!.train();
return Array.from(window.__nisps!.getLossHistory());
},
[EXAMPLE_LOW, EXAMPLE_HIGH],
);
// The pre-§6.5e worker fabricated a 1-element "history" from the final loss.
expect(hist.length).toBeGreaterThan(1);
for (const v of hist) {
expect(Number.isFinite(v)).toBe(true);
expect(v).toBeGreaterThanOrEqual(0);
}
expect(hist[hist.length - 1]!).toBeLessThan(hist[0]!);
});
test('async training publishes the worker net\'s real loss curve too', async ({ page }) => {
const hist = await page.evaluate(
async ([low, high]) => {
window.__nisps!.addExample(low.input, low.output);
window.__nisps!.addExample(high.input, high.output);
await window.__nisps!.trainAsync();
return Array.from(window.__nisps!.getLossHistory());
},
[EXAMPLE_LOW, EXAMPLE_HIGH],
);
expect(hist.length).toBeGreaterThan(1);
for (const v of hist) expect(Number.isFinite(v)).toBe(true);
expect(hist[hist.length - 1]!).toBeLessThan(hist[0]!);
});
test('async training resolves to a finite non-negative loss', async ({ page }) => {
await page.evaluate(
([low, high]) => {
window.__nisps!.addExample(low.input, low.output);
window.__nisps!.addExample(high.input, high.output);
},
[EXAMPLE_LOW, EXAMPLE_HIGH],
);
const loss = await page.evaluate(() => window.__nisps!.trainAsync());
expect(typeof loss).toBe('number');
expect(Number.isFinite(loss)).toBe(true);
expect(loss).toBeGreaterThanOrEqual(0);
});
test('clearExamples resets the dataset count to 0', async ({ page }) => {
await page.evaluate(
([ex]) => window.__nisps!.addExample(ex.input, ex.output),
[EXAMPLE_LOW],
);
expect(await page.evaluate(() => window.__nisps!.getExampleCount())).toBe(1);
await page.evaluate(() => window.__nisps!.clearExamples());
expect(await page.evaluate(() => window.__nisps!.getExampleCount())).toBe(0);
});
test('evalLoss returns a non-negative number or null', async ({ page }) => {
const v = await page.evaluate(() => window.__nisps!.evalLoss());
if (v !== null) {
expect(Number.isFinite(v)).toBe(true);
expect(v).toBeGreaterThanOrEqual(0);
}
});
test('inferBatch returns N * outputSize bounded floats', async ({ page }) => {
const points: ReadonlyArray<readonly [number, number]> = [
[0.0, 0.0],
[0.5, 0.5],
[1.0, 1.0],
];
const flat = await page.evaluate(
(pts) => Array.from(window.__nisps!.inferBatch(pts as [number, number][])),
points,
);
expect(flat).toHaveLength(points.length * N_OUTPUTS);
expect(allWithin(flat, 0, 1)).toBe(true);
});
test('getLayerStats returns 4 floats per layer, all finite', async ({ page }) => {
const stats = await page.evaluate(() => Array.from(window.__nisps!.getLayerStats()));
expect(stats).toHaveLength(LAYER_STATS);
for (const v of stats) expect(Number.isFinite(v)).toBe(true);
});
test('getWeights returns the full weight vector', async ({ page }) => {
const len = await page.evaluate(() => window.__nisps!.getWeights().length);
expect(len).toBe(WEIGHT_COUNT);
});
});