memlnaut-nisps/manifold
monkey-w1n5t0n 1f38f1a7fb fix(engines): restore MEMLCelium's feedback tap (L7)
feedback_/fbzm1_/fb_smooth_alpha_ were read every process() call but nothing
ever wrote feedback_, so the path was silently inert. Git history shows this
was a *muted* feature, not dead code: `feedback = v0 * feedbackGain` with
feedbackGain 0.1f (MEMLCeliumAudioApp.hpp @ d095688), then "0; //0.1f" —
zeroed with the value kept in the comment — then the write was dropped
entirely when the engine was ported to nisps/engines/ at the 2026-04-29
rewrite (8d0d47b). Operator decision: port it back, live at 0.1f.

The tap is voice 0's own enveloped output, post-envelope and pre voice-1/mix/
shape — NOT the final output. This differs from PAFSynth's feedback shape;
where the sibling and the reference disagreed, the reference won.

Not schema-exposed: the reference hardcoded it, and MEMLCelium has no voice
spaces to vary it by. If feedback depth becomes a research axis it wants to be
a runtime parameter — noted, not built.

Verification, and a gap worth recording: parity-check.sh PASSES (max delta
2.38e-7) but that is NOT evidence for this change — its harness only exercises
PAFSynth and ChannelStrip, and the impulse baseline runs all-params-0.5, under
which voice 0's sequencer never triggers, so v0_env stays 0 and the new write
is 0 either way. That baseline is blind to this path, not a check on it. So it
was cross-checked directly instead: sequencer params forced to trigger early,
4800 samples native vs WASM through the nisps_engine_* C ABI —

  native vs WASM max abs diff  1.19e-7   (tolerance 1e-5)
  all 4800 samples nonzero, finite, max amplitude ~0.99 (tanh-bounded)
  same run with gain forced to 0 diverges by up to 1.49 — not a no-op

No fixture regenerated. nisps.wasm ships here because it is a tracked artifact
under the Phase 0 freshness gate.

Follow-up: the parity harness covers 2 of 8 engines. "Firmware and WASM share
the same engines" is asserted repo-wide but tested narrowly.
2026-07-21 17:04:35 +02:00
..
osc-bridge refactor(manifold): delete the OSC bridge twin and dead protocol legs 2026-07-21 12:49:25 +02:00
public fix(engines): restore MEMLCelium's feedback tap (L7) 2026-07-21 17:04:35 +02:00
src refactor(manifold): one applyCurve, one GROUP_COLOR — and make the knob honest 2026-07-21 14:02:48 +02:00
tests fix(manifold): full-width input vector, dropped switches, MIDI churn, re-subscribe churn 2026-07-21 13:22:38 +02:00
.gitignore feat(manifold): dock restructure, settings, backends, shared-core feedback, particle stage 2026-06-28 04:14:30 +02:00
index.html feat(manifold): add convertible React front-end + simplify console chrome 2026-06-28 03:28:45 +02:00
ONBOARDING.md ci: restore verification — reachable submodule pin, codegen + WASM freshness gates 2026-07-21 11:57:32 +02:00
package.json fix(manifold): full-width input vector, dropped switches, MIDI churn, re-subscribe churn 2026-07-21 13:22:38 +02:00
playwright.config.ts feat(manifold): add convertible React front-end + simplify console chrome 2026-06-28 03:28:45 +02:00
tsconfig.json feat(manifold,firmware): restore uSEQ CV/gate as an Outputs backend 2026-06-28 22:30:54 +02:00
vite.config.ts feat(manifold): add convertible React front-end + simplify console chrome 2026-06-28 03:28:45 +02:00