w1n5t0n/memlnaut-nisps
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(modular): duplicate destNames declaration in modular-ui rebuildMatrixGrid

Browse source 
The matrix-seeding edit from the previous commit added a second
`const destNames = engine.destNames || [];` inside rebuildMatrixGrid
while the same name was already declared earlier in the function body.
Chrome threw SyntaxError at parse time, which in turn prevented
a-app.js from wiring window.__nisps at all, which is what made the
earlier FaustWorkletProcessor error look like the root cause — it
was just the next thing that broke once the parse error let partial
modules load.

Verified end-to-end in headless Chromium via Playwright: engine
switches to modular, paramCount=32, audioCtx running, worklet node
live, zero console errors.

Also updates the Modular engine card description to reflect the new
default (32 params = 4 ADSR × 4 + 8 LFO × 2, matrix cells opt-in).
This commit is contained in:
monkey-w1n5t0n 2026-04-11 08:38:56 +02:00
parent fbeedba2f3
commit 575519df68
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
playground/js/a-app.js
View file

@ -1351,8 +1351,8 @@ async function init() {
{ {
id: 'modular', id: 'modular',
displayName: 'Modular', displayName: 'Modular',
paramCount: 512, paramCount: 32,
description: 'Shared mod pool (ADSRs + LFOs) routed through a matrix into a swappable voice. Starts with a 3-osc subtractive sub-engine.', description: 'Shared mod pool (4 ADSRs + 8 LFOs) driving a swappable voice via a routing matrix. Starts with a 3-osc subtractive sub-engine.',
}, },
]; ];
const engineSwitcherEl = document.getElementById('synth-engine-switcher'); const engineSwitcherEl = document.getElementById('synth-engine-switcher');

3
playground/js/ui/modular-ui.js
View file

@ -347,8 +347,7 @@ export function initModularUI({ getEngine, onStateChange } = {}) {
// Seed current values from the engine's _lastRawByLabel map (which // Seed current values from the engine's _lastRawByLabel map (which
// tracks every write via setParam / _setRawByLabel / default patch), // tracks every write via setParam / _setRawByLabel / default patch),
// falling back to the walk-entry init value for cells the user has // falling back to the walk-entry init value for cells the user has
// never touched. // never touched. (destNames is already in scope from the early guard.)
const destNames = engine.destNames || [];
const lastRaw = engine._lastRawByLabel || new Map(); const lastRaw = engine._lastRawByLabel || new Map();
for (let d = 0; d < destNames.length; d++) { for (let d = 0; d < destNames.length; d++) {
const destName = destNames[d]; const destName = destNames[d];