w1n5t0n/memlnaut-nisps
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(a-app): bail out of showGroupDrawer for non-C15 engines

Browse source 
showGroupDrawer indexes into the hardcoded SYNTH_SECTIONS table and
groupOverrides, which only exist for the shaper-feedback engine. For
additive/fm/modular engines, paramToSection is rebuilt dynamically from
paramMeta groups, so region.index points into a larger dynamic section
list and SYNTH_SECTIONS[region.index] is undefined. Hovering a section
label in Modular mode threw "Cannot read properties of undefined
(reading 'name')".

These engines have their own param UIs; the C15 group drawer doesn't
apply. Guard and early-return.
This commit is contained in:
monkey-w1n5t0n 2026-04-11 07:53:37 +02:00
parent afff406d92
commit 2993328859
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
playground/js/a-app.js
View file

@ -3842,6 +3842,10 @@ function wireGroupDrawer() {
}
function showGroupDrawer(region) {
// Group drawer is C15-specific: indexes into the hardcoded SYNTH_SECTIONS
// table and groupOverrides, which only exist for the shaper-feedback engine.
// Other engines (additive, fm, modular) have their own param UIs.
if (activeEngine?.id !== 'shaper-feedback') return;
activeDrawerSection = region.index;
const sec = SYNTH_SECTIONS[region.index];
const ov = groupOverrides[region.index];