w1n5t0n/memlnaut-nisps
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(playground): prevent 1/2 keys being swallowed by focused sliders

Browse source 
When synth controls (volume, tempo, etc.) have focus after dragging,
keyboard shortcuts 1/2 for thumbs down/up were intercepted by the
range input. Now all four UIs skip shortcut handling when an input,
select, or textarea element has focus.
This commit is contained in:
w1n5t0n 2026-03-22 11:52:30 +02:00
parent a0adb8b14b
commit 21832e0099
4 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
playground/js/a-app.js
View file

@ -1176,6 +1176,10 @@ function wireKeyboard() {
}
}
// Don't intercept keys when an input/select has focus
const tag = document.activeElement?.tagName;
if (tag === 'INPUT' || tag === 'SELECT' || tag === 'TEXTAREA') return;
if (e.key === '1' || e.code === 'Numpad1') {
e.preventDefault();
onThumbsDown();

2
playground/js/app.js
View file

@ -432,6 +432,8 @@ function onKeyDown(e) {
}
if (!followMode || e.repeat) return;
const tag = e.target.tagName;
if (tag === 'INPUT' || tag === 'SELECT' || tag === 'TEXTAREA') return;
if (e.key === '1' || e.code === 'Numpad1') {
e.preventDefault();
onThumbsDown();

4
playground/js/b-app.js
View file

@ -1130,13 +1130,13 @@ function clearState() {
// ============================
window.addEventListener('keydown', (e) => {
if (e.repeat) return;
const tag = e.target.tagName;
if (tag === 'INPUT' || tag === 'SELECT' || tag === 'TEXTAREA') return;
// RL shortcuts: 1=negative, 2=positive
if (e.key === '1' || e.code === 'Numpad1') { e.preventDefault(); onThumbsDown(); }
if (e.key === '2' || e.code === 'Numpad2') { e.preventDefault(); onThumbsUp(); }
// Follow mode toggle: f
if (e.key === 'f' || e.key === 'F') {
// Don't toggle if user is typing in an input
if (e.target.tagName === 'INPUT' || e.target.tagName === 'TEXTAREA' || e.target.tagName === 'SELECT') return;
e.preventDefault();
toggleFollowMode();
}

2
playground/js/c-app.js
View file

@ -268,6 +268,8 @@ function init() {
// Keyboard shortcuts for RL (work in all phases)
window.addEventListener('keydown', (e) => {
if (e.repeat) return;
const tag = e.target.tagName;
if (tag === 'INPUT' || tag === 'SELECT' || tag === 'TEXTAREA') return;
if (e.key === '1' || e.code === 'Numpad1') {
e.preventDefault();
onThumbsDown();