From 1127c8aac9ad5a55169b22bcb0caf905a29e142b Mon Sep 17 00:00:00 2001 From: monkey-w1n5t0n Date: Tue, 7 Apr 2026 19:01:55 +0200 Subject: [PATCH] fix: default to visual mode (20 outputs) and fix FlowField canvas resize Change default outputMode from 'synth' to 'visual' in ml-store.ts so FlowField particles render immediately on page load. Fix FlowField component canvas initialization: create visualizer in ResizeObserver callback (after layout) instead of in createEffect (before layout settles), preventing the default 300x150 canvas size issue. Add window resize listener as fallback. Update all 13 affected tests to expect 20 outputs (visual mode default) instead of 126 (synth mode). Unblocks VAL-VIS-001, VAL-VIS-002, VAL-VIS-003. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> --- src/components/visual/FlowField.tsx | 50 +++++++++++++++--------- src/stores/ml-store.ts | 4 +- tests/solidjs/debug-probe.spec.ts | 6 +-- tests/solidjs/ml-store.spec.ts | 16 ++++---- tests/solidjs/reactive-inference.spec.ts | 8 ++-- tests/solidjs/vite-wasm-spike.spec.ts | 8 ++-- 6 files changed, 53 insertions(+), 39 deletions(-) diff --git a/src/components/visual/FlowField.tsx b/src/components/visual/FlowField.tsx index 375d6e4..22b675d 100644 --- a/src/components/visual/FlowField.tsx +++ b/src/components/visual/FlowField.tsx @@ -13,7 +13,6 @@ import { onMount, onCleanup, createEffect, - Show, } from 'solid-js'; import type { MLStore } from '../../stores/ml-store'; import { FlowFieldVisualizer } from '../../core/ui/flow-field'; @@ -28,9 +27,12 @@ export default function FlowField(props: FlowFieldProps) { let visualizer: FlowFieldVisualizer | undefined; let rafId: number = 0; - // Resize handler — updates canvas buffer dimensions + // Resize handler — updates canvas buffer dimensions and reinitializes particles function handleResize(): void { - if (visualizer && canvasRef) { + if (!canvasRef) return; + if (!visualizer) { + visualizer = new FlowFieldVisualizer(canvasRef); + } else { visualizer.resize(); visualizer.initParticles(); } @@ -57,30 +59,42 @@ export default function FlowField(props: FlowFieldProps) { } } + onMount(() => { + if (!canvasRef) return; + + // Set up resize observer — this fires after the canvas has layout dimensions, + // avoiding the default 300x150 canvas size problem + const observer = new ResizeObserver(() => { + handleResize(); + }); + observer.observe(canvasRef); + onCleanup(() => observer.disconnect()); + + // Also handle window resize as fallback + window.addEventListener('resize', handleResize); + onCleanup(() => window.removeEventListener('resize', handleResize)); + }); + // Start/stop render loop based on output mode createEffect(() => { const mode = props.mlStore.state.outputMode; - if (mode === 'visual' && canvasRef) { - if (!visualizer) { - visualizer = new FlowFieldVisualizer(canvasRef); + if (mode === 'visual') { + // If visualizer isn't created yet (e.g. first effect run before ResizeObserver fires), + // create it now — but only if canvas has real dimensions (not default 300x150) + if (!visualizer && canvasRef) { + const rect = canvasRef.getBoundingClientRect(); + if (rect.width > 0 && rect.height > 0) { + visualizer = new FlowFieldVisualizer(canvasRef); + } + } + if (visualizer) { + startLoop(); } - startLoop(); } else { stopLoop(); } }); - onMount(() => { - // Set up resize observer - if (canvasRef) { - const observer = new ResizeObserver(() => { - handleResize(); - }); - observer.observe(canvasRef); - onCleanup(() => observer.disconnect()); - } - }); - onCleanup(() => { stopLoop(); visualizer = undefined; diff --git a/src/stores/ml-store.ts b/src/stores/ml-store.ts index fcc62ab..ff0df5a 100644 --- a/src/stores/ml-store.ts +++ b/src/stores/ml-store.ts @@ -92,14 +92,14 @@ export interface MLStore { export async function createMLStore(bus: SignalBus): Promise { const [state, setState] = createStore({ - outputMode: 'synth', // default mode — old app starts at N_SYNTH_OUTPUTS + outputMode: 'visual', // default mode — FlowField particles render on load midiCCCount: N_MIDI_CC_DEFAULT, spreadLevel: 0.6, initialized: false, }); // Outputs as signal — Float32Array MUST NOT go in store (proxy overhead) - const initialCount = outputCountForMode('synth'); + const initialCount = outputCountForMode('visual'); const [outputs, setOutputs] = createSignal(new Float32Array(initialCount)); const [outputCount, setOutputCount] = createSignal(initialCount); diff --git a/tests/solidjs/debug-probe.spec.ts b/tests/solidjs/debug-probe.spec.ts index 2f116b8..7801ab0 100644 --- a/tests/solidjs/debug-probe.spec.ts +++ b/tests/solidjs/debug-probe.spec.ts @@ -95,7 +95,7 @@ test.describe('Debug Probe (f03)', () => { // ─── Probe method smoke tests ─── - test('probe.getOutputs returns array of 126 bounded values', async ({ page }) => { + test('probe.getOutputs returns array of 20 bounded values (visual mode default)', async ({ page }) => { await loadSolidApp(page); const result = await page.evaluate(() => { @@ -108,7 +108,7 @@ test.describe('Debug Probe (f03)', () => { }); expect(result.isArray).toBe(true); - expect(result.length).toBe(126); + expect(result.length).toBe(20); // visual mode is default expect(result.allBounded).toBe(true); }); @@ -202,7 +202,7 @@ test.describe('Debug Probe (f03)', () => { }); expect(result.length).toBe(3); - expect(result.eachLength).toEqual([126, 126, 126]); + expect(result.eachLength).toEqual([20, 20, 20]); // visual mode default expect(result.allBounded).toBe(true); }); diff --git a/tests/solidjs/ml-store.spec.ts b/tests/solidjs/ml-store.spec.ts index 117508e..3782e9b 100644 --- a/tests/solidjs/ml-store.spec.ts +++ b/tests/solidjs/ml-store.spec.ts @@ -12,7 +12,7 @@ test.describe('ML Store — Dual IML', () => { // ─── VAL-ML-001: Initial outputs bounded [0,1] ─── - test('VAL-ML-001a: getOutputs() returns 126 values on fresh load', async ({ page }) => { + test('VAL-ML-001a: getOutputs() returns 20 values on fresh load (visual mode default)', async ({ page }) => { await loadSolidApp(page); const result = await page.evaluate(() => { @@ -25,7 +25,7 @@ test.describe('ML Store — Dual IML', () => { }); expect(result.isArray).toBe(true); - expect(result.length).toBe(126); + expect(result.length).toBe(20); // visual mode is default }); test('VAL-ML-001b: all initial outputs are in [0,1]', async ({ page }) => { @@ -65,11 +65,11 @@ test.describe('ML Store — Dual IML', () => { // ─── VAL-ML-022: Output count changes with mode ─── - test('VAL-ML-022a: default output count is 126 (synth mode default)', async ({ page }) => { + test('VAL-ML-022a: default output count is 20 (visual mode default)', async ({ page }) => { await loadSolidApp(page); const length = await page.evaluate(() => (window as any).__nisps.getOutputs().length); - expect(length).toBe(126); + expect(length).toBe(20); // visual mode is default }); test('VAL-ML-022b: outputCount signal tracks current count', async ({ page }) => { @@ -80,8 +80,8 @@ test.describe('ML Store — Dual IML', () => { return store.outputCount(); }); - // Default is 126 (synth mode is default) - expect(result).toBe(126); + // Default is 20 (visual mode is default) + expect(result).toBe(20); }); test('VAL-ML-022c: mode change to visual produces 20 outputs', async ({ page }) => { @@ -215,8 +215,8 @@ test.describe('ML Store — Dual IML', () => { expect(result.hasHandIml).toBe(true); expect(result.joyInputs).toBe(2); expect(result.handInputs).toBe(14); - expect(result.joyOutputs).toBe(126); - expect(result.handOutputs).toBe(126); + expect(result.joyOutputs).toBe(20); // visual mode is default + expect(result.handOutputs).toBe(20); // visual mode is default }); test('loss remains null and exampleCount remains 0 after mode switch', async ({ page }) => { diff --git a/tests/solidjs/reactive-inference.spec.ts b/tests/solidjs/reactive-inference.spec.ts index f4f6903..0c7858d 100644 --- a/tests/solidjs/reactive-inference.spec.ts +++ b/tests/solidjs/reactive-inference.spec.ts @@ -77,7 +77,7 @@ test.describe('Reactive Inference Loop (f05)', () => { expect(result.allDifferent).toBe(true); expect(result.allBounded).toBe(true); expect(result.count).toBe(5); - expect(result.eachLength).toBe(126); + expect(result.eachLength).toBe(20); // visual mode default }); test('VAL-ML-004c: changing only X produces different outputs', async ({ page }) => { @@ -140,7 +140,7 @@ test.describe('Reactive Inference Loop (f05)', () => { }; }); - expect(result.length).toBe(126); + expect(result.length).toBe(20); // visual mode default expect(result.allBounded).toBe(true); expect(result.allFinite).toBe(true); // With random weights, outputs shouldn't all be zero @@ -227,7 +227,7 @@ test.describe('Reactive Inference Loop (f05)', () => { }; }); - expect(result.length).toBe(126); + expect(result.length).toBe(20); // visual mode default expect(result.allBounded).toBe(true); expect(result.allFinite).toBe(true); // Clamped values should produce same outputs as explicitly clamped values @@ -392,7 +392,7 @@ test.describe('Reactive Inference Loop (f05)', () => { }); expect(result.hasTopic).toBe(true); - expect(result.afterLength).toBe(126); + expect(result.afterLength).toBe(20); // visual mode default expect(result.changed).toBe(true); }); }); diff --git a/tests/solidjs/vite-wasm-spike.spec.ts b/tests/solidjs/vite-wasm-spike.spec.ts index 94c2a95..57f08ef 100644 --- a/tests/solidjs/vite-wasm-spike.spec.ts +++ b/tests/solidjs/vite-wasm-spike.spec.ts @@ -38,7 +38,7 @@ test.describe('Vite + WASM spike', () => { expect(criticalErrors).toEqual([]); }); - test('VAL-PROJ-003: WASM loads and inference returns 126 bounded outputs', async ({ page }) => { + test('VAL-PROJ-003: WASM loads and inference returns 20 bounded outputs (visual mode default)', async ({ page }) => { await loadSolidApp(page); const result = await page.evaluate(() => { @@ -53,7 +53,7 @@ test.describe('Vite + WASM spike', () => { }; }); - expect(result.length).toBe(126); + expect(result.length).toBe(20); // visual mode is default expect(result.min).toBeGreaterThanOrEqual(0); expect(result.max).toBeLessThanOrEqual(1); expect(result.allBounded).toBe(true); @@ -80,7 +80,7 @@ test.describe('Vite + WASM spike', () => { }); expect(result.same).toBe(false); - expect(result.outputs2Length).toBe(126); + expect(result.outputs2Length).toBe(20); // visual mode default expect(result.outputs2Bounded).toBe(true); }); @@ -143,7 +143,7 @@ test.describe('Vite + WASM spike', () => { }; }); - expect(result.length).toBe(126); + expect(result.length).toBe(20); // visual mode default expect(result.allBounded).toBe(true); expect(result.allFinite).toBe(true); });