88 lines
3.3 KiB
JSON
88 lines
3.3 KiB
JSON
|
|
{
|
||
|
|
"milestone": "output-modes-heatmap",
|
||
|
|
"round": 1,
|
||
|
|
"status": "pass",
|
||
|
|
"validatorsRun": {
|
||
|
|
"test": {
|
||
|
|
"passed": true,
|
||
|
|
"command": "npx playwright test --config playwright-solidjs.config.ts --reporter=line",
|
||
|
|
"exitCode": 0,
|
||
|
|
"details": "214/214 tests passed in 55.2s"
|
||
|
|
},
|
||
|
|
"typecheck": {
|
||
|
|
"passed": true,
|
||
|
|
"command": "npx tsc --noEmit",
|
||
|
|
"exitCode": 0,
|
||
|
|
"details": "No type errors"
|
||
|
|
},
|
||
|
|
"lint": {
|
||
|
|
"passed": true,
|
||
|
|
"command": "npx eslint src/ --ext .ts,.tsx 2>/dev/null || true",
|
||
|
|
"exitCode": 0,
|
||
|
|
"details": "No eslint.config file exists (expected — services.yaml uses || true). No lint issues."
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"reviewsSummary": {
|
||
|
|
"total": 3,
|
||
|
|
"passed": 3,
|
||
|
|
"failed": 0,
|
||
|
|
"failedFeatures": []
|
||
|
|
},
|
||
|
|
"blockingIssues": [],
|
||
|
|
"nonBlockingIssues": [
|
||
|
|
{
|
||
|
|
"featureId": "f13-output-mode-switching",
|
||
|
|
"severity": "non_blocking",
|
||
|
|
"description": "Undo stack and loss history are not cleared on destructive resize (mode switch with examples). Users could undo past a mode switch boundary, seeing stale undo/loss state."
|
||
|
|
},
|
||
|
|
{
|
||
|
|
"featureId": "f13-output-mode-switching",
|
||
|
|
"severity": "non_blocking",
|
||
|
|
"description": "Confirmation dialog uses window.confirm() which is functional but stylistically inconsistent with the app's glass morphism custom UI."
|
||
|
|
},
|
||
|
|
{
|
||
|
|
"featureId": "f14-heatmap-strip",
|
||
|
|
"severity": "non_blocking",
|
||
|
|
"description": "Unnecessary `as any` cast when calling _updateOutputs on MLStore — the method is on the interface, so direct access would be type-safe."
|
||
|
|
},
|
||
|
|
{
|
||
|
|
"featureId": "f14-heatmap-strip",
|
||
|
|
"severity": "non_blocking",
|
||
|
|
"description": "_index parameter naming inconsistency: underscore prefix conventionally signals unused, but the parameter IS used in the function body."
|
||
|
|
},
|
||
|
|
{
|
||
|
|
"featureId": "f14-heatmap-strip",
|
||
|
|
"severity": "non_blocking",
|
||
|
|
"description": "createCellHandlers() creates new closures per cell per render — minor efficiency concern, fine with <=126 bars."
|
||
|
|
},
|
||
|
|
{
|
||
|
|
"featureId": "f15-param-popup",
|
||
|
|
"severity": "non_blocking",
|
||
|
|
"description": "applyAllOverrides() is defined on MLStore but never called — overrides are stored but not wired into actual output routing pipeline. Acceptable scope for this milestone."
|
||
|
|
}
|
||
|
|
],
|
||
|
|
"appliedUpdates": [
|
||
|
|
{
|
||
|
|
"target": "library",
|
||
|
|
"file": ".factory/library/architecture.md",
|
||
|
|
"description": "Fixed docs typo: `applyAllOutputs(Float32Array)` → `applyAllOverrides(Float32Array)` in Param Override System section",
|
||
|
|
"sourceFeature": "f15-param-popup"
|
||
|
|
},
|
||
|
|
{
|
||
|
|
"target": "library",
|
||
|
|
"file": ".factory/library/architecture.md",
|
||
|
|
"description": "Added ModeDrawer component documentation (pill toggle UI, output mode switching)",
|
||
|
|
"sourceFeature": "f13-output-mode-switching"
|
||
|
|
},
|
||
|
|
{
|
||
|
|
"target": "library",
|
||
|
|
"file": ".factory/library/architecture.md",
|
||
|
|
"description": "Added important note that applyAllOverrides() is not yet wired into output pipeline — future workers implementing output routing must call this method",
|
||
|
|
"sourceFeature": "f15-param-popup"
|
||
|
|
}
|
||
|
|
],
|
||
|
|
"suggestedGuidanceUpdates": [],
|
||
|
|
"rejectedObservations": [],
|
||
|
|
"previousRound": null
|
||
|
|
}
|